Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SockJSConnection.on_open return value is ignored #99

Open
kupuguy opened this issue Jan 27, 2016 · 0 comments
Open

SockJSConnection.on_open return value is ignored #99

kupuguy opened this issue Jan 27, 2016 · 0 comments

Comments

@kupuguy
Copy link

kupuguy commented Jan 27, 2016

The documentation for SockJSConnection.on_open says "If you return False, connection will be rejected", but in fact the only call to on_open in session.py/ConnectionInfo.verify_state ignores the returned value:

        self.conn.on_open(self.conn_info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kupuguy