Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize block settings and defaults via theme.json #36

Closed
mrwweb opened this issue Jan 28, 2023 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@mrwweb
Copy link
Owner

mrwweb commented Jan 28, 2023

I often want to hard-code one or more of the settings this block provides. In those cases, it would be nice to allow removing the various settings from the editor interface. I think I've seen examples of this done through theme.json in settings.blocks.mrw\accordion so, for instance, I could either set a default icon that's different from the plugin default OR remove the icon setting altogether.

See also: #5 for thinking about custom expand/collapse icons

@mrwweb mrwweb added the enhancement New feature or request label Jan 28, 2023
@mrwweb
Copy link
Owner Author

mrwweb commented Apr 16, 2024

Closing. This is what block variations are for, especially now that they can be made in PHP or JS!

@mrwweb mrwweb closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant