Skip to content

Latest commit

 

History

History
84 lines (61 loc) · 2.55 KB

review.md

File metadata and controls

84 lines (61 loc) · 2.55 KB

Review Open Issues

  1. Short Github Project Description (oriented Ralfs description A Link to or copy pased?)
  • Sample Hello World raus
-> done! (tku)
  • Sample Counter - Counter raus, Beiden Resolver Repository raus (ggf. repo -> ...), Client Sample etwas anpassen
-> done! (tku)

  1. Should be a pure Java Library - Web Socket Implementation based Jetty - Michael

  2. Autoconfiguration should be moved to the starter project - Edgar

  3. GSWebSocketHandler should be revised to much handler functions and cloud be improved - Torsten (Pair Reviewing am Dienstag)

-> done! (tku)

  1. GsGraphQLStandardSchemaCreator vs. GsGraphQLSchemaCreator what is the difference, what do we need? - initScalarTypes Was ist das - Torsten

    • interface GsGraphQLSchemaCreator
      • create()
      • getGraphQLSchema()
    • abstract class GsGraphQLAbstractSchemaCreator implements GsGraphQLSchemaCreator
      • impementiert: getGraphQLSchema()
      • initScalarTypes()
    • class GsGraphQLSimpleSchemaCreator extends GsGraphQLAbstractSchemaCreator
      • ruft initScalarTypes() auf
      • von uns genutzt in GsAutoConfiguration
    • class GsGraphQLStandardSchemaCreator extends GsGraphQLAbstractSchemaCreator
      • unbenutzt
    • new GttUuidType() in initScalarTypes kann ersetzt werden durch:
      • @Autowired
      • GttUuidType gttUuidType;

  2. GsGraphQLEngine Why do we have no interface there but for GsGraphQLExecution - Torsten

-> done! (tku)
  1. GsGraphQLStandardSchemaCreator Why explizit @Scope(singelton) bitte raus? - Torsten
-> done! (tku)
  1. In many classes the Calss Documentation is missing - Torsten
-> done! (tku)

  1. Motivation of GraphQLIOLibraryGsConfiguration & GraphQLIOLibraryGsConfiguration - Edgar (Autoconfiguration)

  2. Production Configuration Properties are missing - Edgar

  3. Some Configuration Properties are unclear. Why do we need graphql.servlet.mapping for example - Edgar (Autoconfiguration)

  4. GraphQL Schema places an file naming should be changed - Michael

  5. Naming Method Convention whenThenElse for all Tests - Torsten

-> done! (tku)

  1. Property Generator for our Properties is missing - Edgar (Autoconfiguration)

  2. Samples werden nicht im Eclipse angezeigt, da die Sample Folder nicht automatisch in den Classpath ... - Torsten Nachdenken

-> look in wsf: pom.xml
  1. Maven Ich will Samples nicht ausliefern ... ? - Torsten Nachdenken
-> look in wsf: pom.xml
  1. Maven Ich will Test nicht ausliefern ... ? - Torsten Nachdenken