Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow with larger messages #14

Open
hcarty opened this issue May 25, 2016 · 3 comments
Open

Slow with larger messages #14

hcarty opened this issue May 25, 2016 · 3 comments

Comments

@hcarty
Copy link

hcarty commented May 25, 2016

The internal representation of bytes as bool tuples and the splitting of strings into list contributes to the slow performance. A messages with a 64kb string takes close to 100ms to parse on a test machine, far longer than I would expect for such a simple operation.

Is the representation of the message content something that can be changed in the Coq code or would it require a rewrite by hand in OCaml?

@mzp
Copy link
Member

mzp commented Jun 5, 2016

To change internal representanion, Coq code should be changed, especially at extract config( https://github.com/msgpack/msgpack-ocaml/blob/master/proof/ExtractUtil.v).

@kitefishlabs
Copy link

@hcarty: any luck with changing the underlying representation? I'm trying to get this to work with large messages.

@vbmithr
Copy link
Contributor

vbmithr commented Aug 11, 2016

Check out http://github.com/vbmithr/ocaml-msgpck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants