Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an healthcheck endpoint without authentication #108

Open
ludopaquet opened this issue Oct 10, 2024 · 3 comments
Open

Add an healthcheck endpoint without authentication #108

ludopaquet opened this issue Oct 10, 2024 · 3 comments

Comments

@ludopaquet
Copy link

It could be nice especially for k8s if we could expose a /healthcheck or /ping without httpauth in any case. For liveness/readiness probe.

Thanks !

@msoap
Copy link
Owner

msoap commented Oct 10, 2024

Hi @ludopaquet, installing the auth-check independently for each command is not available. I want to keep the utility as simple as possible. And setup auth per-command will complicate the interface too much. Alternatively there are two solutions:

  • disable global auth and check auth header inside shell-command where it needed
  • or add auth to the URL in k8s like: http://user:pass@host/healthcheck

@ludopaquet
Copy link
Author

Understood.
However, my intention is not to have auth per command but just one single point (like index) without auth in any case. Maybe I can propose a PR and you will decide if it's good for you or not ?

@ludopaquet
Copy link
Author

ludopaquet commented Oct 11, 2024

here my PR:
#109

I could document and even make this path customizable from the command line if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants