Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance enhancements #9

Open
shaunmauer opened this issue Nov 23, 2017 · 1 comment
Open

Performance enhancements #9

shaunmauer opened this issue Nov 23, 2017 · 1 comment

Comments

@shaunmauer
Copy link

Hi

Some performance enhancement suggestions:

  • When calling apex_json.write to set boolean values, dont put the true/false in quotes. It generates a string and not a boolean value. If I look at the DOM for the tree, some of the boolean parameters are being processed as undefined as they are generated as a string

  • Include the is_leaf column in the SQL query (if you use the connect by statement to generate the tree structure. You can rather use this to check if the node has children, instead of running another SQL statement. This requires a change to all the variables that are used when looping through the columns.

Regards,
Shaun

@shaunmauer
Copy link
Author

Hi @mt-ag

Not sure if you are still considering this, but I have made quite a few customization's if you are interested.

Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant