Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json payload ignored when a tag is not found #484

Closed
neildes2 opened this issue Aug 20, 2024 · 4 comments · Fixed by #492
Closed

Json payload ignored when a tag is not found #484

neildes2 opened this issue Aug 20, 2024 · 4 comments · Fixed by #492
Assignees
Labels

Comments

@neildes2
Copy link
Collaborator

For MQTT Ingress, when any one of the tags is not found in the device file, the entire payload gets dumped. shdr does not work in this fashion. You can send any tag in shdr and it will just get ignored. MQTT ingest should function like shdr and just ignore the one tag.
Tested with Agent v2.3.0.16

ex.
In the json payload below, if the tag "blah" is not found in the device file, none of the other tags get processed. The entire payload and all its tags gets dumped. This is not a format error, it's just that one of the tags does not exist.

{
"exec": "ACTIVE",
"blah": "BLAH",
"avail": "AVAILABLE"
}

@wsobel
Copy link
Member

wsobel commented Aug 28, 2024

I will take a look and verify. You are correct the error should be logged and then ignored. It is probably in the logic to stop on error.

Best
Will Sobel

@wsobel wsobel added the bug label Aug 28, 2024
@neildes2
Copy link
Collaborator Author

This is becoming a hot issue. Any push to getting resolved would be great.

@wsobel
Copy link
Member

wsobel commented Sep 26, 2024

I'll queue it up for the next release. Any additional information or test files would be helpful.

@rajwork9 rajwork9 self-assigned this Sep 27, 2024
@wsobel wsobel linked a pull request Sep 30, 2024 that will close this issue
@neildes2
Copy link
Collaborator Author

neildes2 commented Oct 9, 2024

tested with v2.4.0.4. Working great! Thanks Will! Love the logging as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants