Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

Current agent buffer size is 2^17, should be similar size #6

Open
wsobel opened this issue Mar 8, 2017 · 4 comments
Open

Current agent buffer size is 2^17, should be similar size #6

wsobel opened this issue Mar 8, 2017 · 4 comments

Comments

@wsobel
Copy link
Member

wsobel commented Mar 8, 2017

We need to make the buffer size at least 32k by default to allow for adequate space in the circular buffer. We need to test the amount of memory this takes for initial configuration.

The current default size of 10 is far too small.

@wsobel wsobel assigned wsobel and andrewshatnyy and unassigned wsobel Mar 8, 2017
@wsobel
Copy link
Member Author

wsobel commented Mar 8, 2017

The tests rely on the buffer size being 10, we need to have the tests set this explicitly.

@wsobel
Copy link
Member Author

wsobel commented Apr 7, 2017

Priority 2

@andrewshatnyy
Copy link
Collaborator

andrewshatnyy commented Apr 21, 2017

@wsobel So there are few plces where this is used

const bufferSize = Number(config.app.agent.bufferSize)

Which should be what size?
const assetBuffer = new CBuffer(1024) // TODO pass from config

@andrewshatnyy
Copy link
Collaborator

lokijs is not handling 32k record insertion well.
Just found that https://github.com/mtconnect/mtconnect-agent/blob/2e0508af679222998a53526c183ba851d89c1c22/src/jsonToXML.js has both buffer values hardcoded

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants