Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Wishlist #2

Open
jletey opened this issue Jul 28, 2019 · 7 comments
Open

Icon Wishlist #2

jletey opened this issue Jul 28, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@jletey
Copy link

jletey commented Jul 28, 2019

Here is where users can post icons that they to be added the the Daybreak theme

@mtdmali, please note that I'm an up-and-coming designer, so I'd be more than happy to help you out with icon designs. Also, I'm currently simplifying/updating the current icons so that they are more even and centred ... you can look at my progress on Figma

@mtdmali
Copy link
Owner

mtdmali commented Jul 28, 2019

@johnletey Thanks for your enthusiasm!

The icons included with Daybreak are straight from Chalice Icon Theme, I simply edited the fill colors on the SVGs to better match this theme.

The reason I included the Chalice icons is because of their relative simplicity; I found their designs to be consistent and not as distracting as a million differently shaped / colored logo icons that you see in other icon themes.

Feel free to suggest any additions / alterations!

@jletey
Copy link
Author

jletey commented Jul 28, 2019

Feel free to suggest any additions / alterations!

Wonderful! When I'm done updating the current icons, I'll post back here with the comparisons!

@jletey
Copy link
Author

jletey commented Jul 28, 2019

All of the icons mentioned below can be found in this Figma file

((( So sorry for the amount of screenshots ... and the varying sizes in screenshots )))

Updated Icons

bracket

Before After

code

Before After

console

Before After

curly

Before After

document

Before After

folder-expanded

Before After

folder

Before After

image

Before After

lambda

Before After

lisp

Before After

markdown

Before After

style

Before After

New Icon: Git

With the current icons, the git files (e.g. .gitignore) are under the document icon, which I don't think quite suits them

So, I've designed a new icon:

Shot 2019-07-28 at 17 57 35

Let me know what you think @mtdmali!

@mtdmali
Copy link
Owner

mtdmali commented Jul 30, 2019

@johnletey I've left some comments in the Figma file itself. Fantastic work!

@mittalyashu
Copy link

Hello @mtdmali,

@johnletey has created all these icons based on feather icon.

Also, @johnletey few of the icons you have created are not in the feature icon issue list or on the website, can you do the same for the curly, folder, lambda, lisp, hash, and markdown.

@jletey
Copy link
Author

jletey commented Jul 30, 2019

@johnletey has created all these icons based on feather icon.

Actually @mittalyashu, I did not ... I simply traced the old icons, but then set the stroke properties to be the same as the ones used in the Feather icon set ... so having round line caps and having rounded corners (note that the stroke width isn't 2px ... but actually 3 or 4px)

The only one that I've taken directly from the Feather Icons would be the package icon, but I'm going to change the stroke width on that one

Also, @johnletey few of the icons you have created are not in the feature icon issue list or on the website, can you do the same for the curly, folder, lambda, lisp, hash, and markdown.

So you want me to add these icons to the Feather Icons library? I'll have to resize from 64x64px to 24x24px and change the stroke width ... but I can if you'd like

@mittalyashu
Copy link

Actually @mittalyashu, I did not ... I simply traced the old icons, but then set the stroke properties to be the same as the ones used in the Feather icon set ... so having round line caps and having rounded corners (note that the stroke width isn't 2px ... but actually 3 or 4px)

My bad! 😅

So you want me to add these icons to the Feather Icons library? I'll have to resize from 64x64px to 24x24px and change the stroke width ... but I can if you'd like

Sure, maybe create a new issue for each icon, so that we can discuss the icon in detail.

@mtdmali mtdmali added the enhancement New feature or request label Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants