-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Transaction UX #1630
Comments
You can click on the remainder in order to copy it to the clipboard (#806)
It seems as accurate as it gets to me. What alternative do you suggest?
Actually, we do not allow the sum of the parts to differ from the available fund for the split, but we update the sum automatically, which is a bug: #1349
The only element that I am aware of that do not respect the recommended minimum touch target size of 48dp are the rows in the part list. I am afraid, doubling their height would make the interface look quite far-stretched. |
@mtotschnig Maybe not doubling the row height, just consider a more touch-friendly approach? In general the app is quite touch friendly, except few details which I believe arise due some design inconsistencies. |
@mtotschnig |
@klaviartur that's still too ambiguous because it doesn't tell if you still have funds left, or splits sum greater than available funds. The current error tells "There is still some amount left unsplit", but that is incorrect when splits sum greater than available funds (entire amount has been split AND THEN SOME). But the error tells you there is more to split. |
@derei Your screenshot shows unsplit amount: 5, meaning 5 over budget. It there was funds left, it would say unsplit amount: -5 It's simply and mathamatically: Total - Sum(Parts), in your case: -50 - (-20 + -35) = -50 + 55 = 5 Yeah, I agree, it's not the most intuitive thing in the world, if you see it for the first time, but as a long time user I have to say that I had no trouble getting used to it immediately and never got confused again. Would you like |
@klaviartur good design means you don't have to "figure it out" and getting it wrong the first time, even if you don't confuse it in the future. You may not realise it, but the subconscious effort we put in using various apps and technologies nowadays is taking a toll on us. Unified design is not just for things to be pretty: its purpose is mainly to relieve the pressure of having to figure things out. I would rethink a bit the UI/UX, rather than keeping my focus narrowed to a warning message. Can it be done different, so it doesn't need the error message, but inform the user in a more direct/intuitive way? Most probably. But it would require some brainstorming. |
@mtotschnig If total is already set (i.e. not calculated automatically from parts), it would be very nice, if the amount field of every new part was initialized with the remainder. As it is the selected field to type into anyway one can either type a different amount or keep it and change everything else. This would be more streamlined than #806 |
@derei Let's brainstorm then. From my viewpoint you can do one (or more) of three things:
I think, we can agree that no. 1 is desirable in any case and we additionally have to choose between 2 and 3. Now, how to do no.1? As we agree that the pure maths and the needed and interpretation of the sign of the difference is unintuitive, how about using words? Sidenote: the mathematical implementation is even more complicated than that, because parts can have opposite sign from total, but I won't go into the details here. It is solvable anyway. Another Sidenote: In german I would suggest "Unverteilter Betrag" and "Überverteilter Betrag" The sign of the difference would then have to be always the same as the sign of the total or omitted entirely. As for the choice between nos. 2 and 3, there has been a decision in #497 to not automatically change the total, which is sensbile in my opinion. But of course one can reevaluate the option of asking the user whether they want to recalculate the total. In any case you cannot just not save without an explanation. If not a error message then there has to be another hint, why save cannot be applied, e.g. highlighting/flashing of the previously described line "unsplit/oversplit amount". One could even grey out the save button while there is a difference (and still give message or highlighting difference line when user taps it anyway) Your thoughts!? |
@klaviartur @mtotschnig I believe it is going in the right direction. Building on what you proposed (and going back a little), I suggest:
What do the above achieve:
|
While I appreciate your fresh outside view on the app and can only agree, that an equal sign does not make me think of a calculator, I personally feel your demands are quite far-reaching and as such do not have a great probability of being implemented soon. I personally like to salvage quick wins which give most of the improvements with minimal effort.
will have the most gain per effort. In the end, we are just users, of course. It is up to @mtotschnig to decide what to do. |
@klaviartur those weren't demands, but suggestions. In the end, the app development will go the way the developer(s) want it to go. Best, and good luck! |
@klaviartur @derei Thanks for sharing and discussing your inspiring ideas! I'll take them up one way or the other, but will need some time to navigate the trade-off between effort and available time. For the moment, just some quick thoughts:
|
@mtotschnig You could try 32dp for the row... perhaps it will suffice without spreading things too much. |
Good idea. I will try that. In version, 3.9.4, #1349 will be fixed, thus addressing the third point of the original list. |
Would like to kindly bump that as I fear it might get overseen in this rather lengthy thread and it's very important to me and also seems to be a minor effort. |
The notes row's height is dynamically adjusting on my side. Could you post specs of the device and screenshot or recording of your mileage? |
This is an excellent remark. Unfortunately the current design is due to a legacy architecture, that I won't be able to change reasonably soon. For the moment I will adopt @klaviartur 's suggestion (extracted to #1633) of initializing the edit screen for the part with the remainder, thus providing a minimum of that context information. |
Split transaction seems either buggy, or unintuitive.
Simplest way to explain would be by screenshots:
Split transaction with the sum of the parts greater than the whole (available: 50, splits sum: 55).
When attempting to save, the error warns about unsplit amount.
![Image](https://private-user-images.githubusercontent.com/34483372/404579166-15368be3-2c53-4f44-a2db-1fd75b7f1d0e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjgzMTcsIm5iZiI6MTczOTU2ODAxNywicGF0aCI6Ii8zNDQ4MzM3Mi80MDQ1NzkxNjYtMTUzNjhiZTMtMmM1My00ZjQ0LWEyZGItMWZkNzViN2YxZDBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIxMjAxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJlZWMxMjE3YWEwMzgwMWM4MDg5ZDEyZWE1ZWI3YjFlOTE5MDk3NDBjZjM2ODY0YWE3N2VjZTE5YmY1ZDU3NzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vXWBgibEQKkyZqc4y-U9Wg7dkLNdGbaAgntSd0Me30U)
Values were corrected to sum 50, and now transaction can be saved.
The saved transaction can be edited however.
I modified the 30 split into 35 and I was able to save. Now the result shows -55.
![Image](https://private-user-images.githubusercontent.com/34483372/404579477-1c20e3c6-c8d1-4ab8-b267-1d1c0063eada.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjgzMTcsIm5iZiI6MTczOTU2ODAxNywicGF0aCI6Ii8zNDQ4MzM3Mi80MDQ1Nzk0NzctMWMyMGUzYzYtYzhkMS00YWI4LWIyNjctMWQxYzAwNjNlYWRhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIxMjAxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRlZjZjOTQzMjg4YzA4ZGRjYTE0ODM3M2I2ODY4OWJkYmQ4NDYzOTkyNjliMDlkOTMzNzE2ZTlkYzdiMWI3ZTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.p9sRGQEKGK_bLn2rhnFtfxkpJeh5YRI34L094rQiUq4)
I see several issues here:
Mention: I am only dry testing the app for now, trying to figure it out.
The text was updated successfully, but these errors were encountered: