Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog, AlertDialog] Dialogs are unlabeled #1325

Open
aarongarciah opened this issue Jan 11, 2025 · 0 comments · May be fixed by #1326
Open

[Dialog, AlertDialog] Dialogs are unlabeled #1325

aarongarciah opened this issue Jan 11, 2025 · 0 comments · May be fixed by #1326
Assignees
@michaldudak
Labels
bug 🐛 Something doesn't work component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module!

Comments

@aarongarciah
Copy link
Member

aarongarciah commented Jan 11, 2025 •
edited
Loading

Bug report

Current behavior

Dialog and AlertDialog are not properly labeled because the Title and Description parts don't have an id. The the aria-labelledby and aria-describedby attributes point to non-existent ids. See attached screenshot.

Screenshot 2025-01-11 at 21 23 49

Expected behavior

Dialog and AlertDialog should be properly labeled by the Title and Descriptions parts.

Reproducible example

https://codesandbox.io/p/sandbox/base-ui-dialog-nested-without-nesting-forked-d2sjnf?workspaceId=ws_HE9JRzFW36Y2kpBoSwdvZ5

Base UI version

v1.0.0-alpha.5
@aarongarciah aarongarciah added component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! labels Jan 11, 2025
@aarongarciah aarongarciah changed the title [Dialog, AlertDialog] Unlabelled dialogs [Dialog, AlertDialog] Dialogs are unlabeled Jan 11, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Base UI Jan 11, 2025
@mj12albert mj12albert linked a pull request Jan 12, 2025 that will close this issue
Open
1 task
@mj12albert mj12albert added the bug 🐛 Something doesn't work label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaldudak michaldudak

Labels
bug 🐛 Something doesn't work component: alert dialog This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module!
Projects
Base UI
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dialogs] Fix missing ids on Title and Description mj12albert/base-ui
3 participants
@michaldudak @mj12albert @aarongarciah