Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] RTLProvider missing from @mui/system but used in x-date-pickers #14781

Closed
metinjakupi opened this issue Sep 30, 2024 · 17 comments
Closed
Labels
component: pickers This is the name of the generic UI component, not the React module! status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it

Comments

@metinjakupi
Copy link

metinjakupi commented Sep 30, 2024

Steps to reproduce

I was using the version 7.0.0 and it was working suddenly i checked the code and i see this i added
import { useRtl } from '@mui/system/RtlProvider';
but before this it was like this

const theme = useTheme();
const isRTL = theme.direction === 'rtl';

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
System:
    OS: macOS 14.6.1
  Binaries:
    Node: 20.17.0 - ~/.nvm/versions/node/v20.17.0/bin/node
    npm: 10.8.2 - ~/.nvm/versions/node/v20.17.0/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 129.0.6668.60
    Edge: Not Found
    Safari: 17.6
  npmPackages:
    @emotion/react: 11.10.8 => 11.10.8 
    @emotion/styled: 11.10.8 => 11.10.8 
    @mui/base:  5.0.0-alpha.127 
    @mui/core-downloads-tracker:  5.16.7 
    @mui/lab: 5.0.0-alpha.128 => 5.0.0-alpha.128 
    @mui/material: 5.12.2 => 5.12.2 
    @mui/styled-engine:  5.16.6 
    @mui/system: 5.12.1 => 5.12.1 
    @mui/types:  7.2.17 
    @mui/utils:  5.16.6 
    @mui/x-data-grid: 6.0.3 => 6.0.3 
    @mui/x-date-pickers: ^6.19.7 => 6.19.7 
    @types/react: 18.2.0 => 18.2.0 
    react: ^18.3.1 => 18.3.1 
    react-dom: ^18.3.1 => 18.3.1 
    typescript: 5.0.4 => 5.0.4 

Search keywords: RTL

@metinjakupi metinjakupi added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 30, 2024
@flaviendelangle
Copy link
Member

You are using the version @mui/material: 5.12.2
We support version 5.15.14 and above

Upgrading should fix your problem

@flaviendelangle flaviendelangle added status: waiting for author Issue with insufficient information and removed bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 1, 2024
@LukasTy LukasTy added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it component: pickers This is the name of the generic UI component, not the React module! labels Oct 1, 2024
@metinjakupi
Copy link
Author

Thanks i will try now, but this is strange cause i didn't update anything i had 7.0.0 from months ago and the same material version

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 1, 2024
@flaviendelangle
Copy link
Member

We started using RtlProvider in a minor version of @mui/x-date-pickers, but the minimal supported version of @mui/material had been bumped for v7.0.0.

So my understanding is that before you had an incompatible version of @mui/material, but it was not causing any issue because we weren't using any feature that you did not have in your version of @mui/material.

@metinjakupi
Copy link
Author

The problem is cause i am using a theme and that has defined settings and if i update the material mui the whole theme is crashed, so should i downgrade the x-date-picker to 6.9?

@flaviendelangle
Copy link
Member

It's weird that you cannot update @mui/material since it's just a minor (if you tried to update to their last v5 release and not the v6 release which includes a handfull of breaking changes)
If you have a problem, don't hesitate to create an issue on their repo.
Downgrading @mui/x-date-pickers is of course a solution but not the best one for you.

@flaviendelangle flaviendelangle added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 1, 2024
@flaviendelangle flaviendelangle changed the title RTLProvider missing from @mui/system but used in x-date-pickers [pickers] RTLProvider missing from @mui/system but used in x-date-pickers Oct 1, 2024
@metinjakupi
Copy link
Author

I will downgrade for now cause it will cause me bigger problems, their palette stuff also is old

Error: MUI: Unsupported 47, 43, 61 color.
The following formats are supported: #nnn, #nnnnnn, rgb(), rgba(), hsl(), hsla(), color().

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 1, 2024
@LukasTy
Copy link
Member

LukasTy commented Oct 1, 2024

@metinjakupi could you provide a minimal reproduction example to see your problem in action?
A live example would be perfect. This guide should be a good starting point. Thank you!

@LukasTy LukasTy added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 1, 2024
@metinjakupi
Copy link
Author

@LukasTy There are a lots of custom confifgurations there are overrides of react-mui inputs with the themes one, so i think it is better to downgrade :/

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 1, 2024
@LukasTy
Copy link
Member

LukasTy commented Oct 1, 2024

There are a lots of custom confifgurations there are overrides of react-mui inputs with the themes one, so i think it is better to downgrade :/

Whatever works best for you. 👌
But you will probably have to bump the versions sooner or later. Hence, I would try to spend some effort to unblock the @mui/material bump sooner rather than later. 🤔

@LukasTy LukasTy added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 1, 2024
@metinjakupi
Copy link
Author

We can be in touch, i would like to upgrade to mui 5.15

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 1, 2024
@LukasTy
Copy link
Member

LukasTy commented Oct 1, 2024

We can be in touch, i would like to upgrade to mui 5.15

We would like not to keep issues that have nothing actionable open.
I'm closing it as the root cause of the issue seems clear.
If you still experience issues upgrading to the latest v5 of @mui/material—feel free to open an issue on their repository if the problem is with that library. 👌 😉

@LukasTy LukasTy closed this as completed Oct 1, 2024
@LukasTy LukasTy removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @metinjakupi! How was your experience with our support team?
We'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

@caelus-dev
Copy link

caelus-dev commented Oct 20, 2024

Hi, I have similar problem. The case is different, but the error is similar, so I didn't open a new ticket.

I used @mui/material: "^5.16.7" and @mui/x-date-pickers: "^7.21.0".
I wanted to upgrade material ui to v6, but I got the following errors:

[ERROR] Could not resolve "@mui/system/RtlProvider"
[ERROR] Could not resolve "@mui/system"

These errors are from mui/x-date-pickers.

In the official documentation the only thing is mentioned in the v5 to v6 migration section about date picker is:

MUI X packages do not follow the same versioning strategy as Material UI. If you're using any of the following packages, they should remain unchanged during the upgrade process

I did exactly what the document said. Changed the mui version to "^6.1.4" and left the date picker untouched. So I don't understand. Can't the mui/x-date-pickers be used with v6 material ui? Or what's the problem?

@flaviendelangle
Copy link
Member

flaviendelangle commented Oct 21, 2024

Hi,
Could you indicate to me which version of @mui/system ended up being installed when you had the error?
It would be even better if you could create a new issue to have a clean start 👍

@caelus-dev
Copy link

Hi, Could you indicate to me which version of @mui/system ended up being installed when you had the error? It would be even better if you could create a new issue to have a clean start 👍

@mui/system is totally missing and I didn't put it into the packages, because in the installation guide there is no mention about it, or maybe I missed something.

If my answer doesn't resolve the problem and more details are necessary, I will open a new ticket.

@flaviendelangle
Copy link
Member

Please open a new ticket 👍
You should have @mui/system installed automatically @mui/material but we'll find what's wrong

@caelus-dev
Copy link

Please open a new ticket 👍 You should have @mui/system installed automatically @mui/material but we'll find what's wrong

Thank you, I opened a ticket for the problem: #15267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it
Projects
None yet
Development

No branches or pull requests

4 participants