Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] When using aggregations, UI of column header labels doesn't look good #14880

Closed
stivluc opened this issue Oct 8, 2024 · 4 comments
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature status: waiting for author Issue with insufficient information support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@stivluc
Copy link

stivluc commented Oct 8, 2024

Steps to reproduce

Example in this image, using SUM for the "Colis" column.
image

Example when using density = 'standard':
Uploading image.png…

Current behavior

The aggregation column header label overlaps the field name when the grid density is compact.

Expected behavior

It should look the same as when using density standard, maybe with less padding / margin.

Context

No response

Your environment

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.19045
  Binaries:
    Node: 22.6.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: Not Found
  Browsers:
    Chrome: Not Found
    Edge: Chromium (127.0.2651.98)
  npmPackages:
    @emotion/react: ^11.10.6 => 11.13.3
    @emotion/styled: ^11.10.6 => 11.13.0
    @mui/base:  5.0.0-beta.40
    @mui/core-downloads-tracker:  5.16.7
    @mui/icons-material: ^5.11.16 => 5.16.7
    @mui/lab: ^5.0.0-alpha.126 => 5.0.0-alpha.173
    @mui/material: ^5.12.0 => 5.16.7
    @mui/private-theming:  5.16.6
    @mui/styled-engine:  5.16.6
    @mui/system:  5.16.7
    @mui/types:  7.2.15
    @mui/utils:  5.16.6
    @mui/x-data-grid:  6.20.4
    @mui/x-data-grid-premium: ^6.19.6 => 6.20.4
    @mui/x-data-grid-pro:  6.20.4
    @mui/x-date-pickers: ^6.18.2 => 6.20.2
    @mui/x-date-pickers-pro: ^6.19.5 => 6.20.2
    @mui/x-license-pro:  6.10.2
    @types/react:  18.3.4
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript:  5.5.4

Search keywords: UI Header Labels Aggregations
Order ID: 80196

@stivluc stivluc added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 8, 2024
@github-actions github-actions bot added component: data grid This is the name of the generic UI component, not the React module! support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/ labels Oct 8, 2024
@michelengelen
Copy link
Member

We are currently working on a rebrush of the header cells and changes to the aggregation view are included afaik.
@KenanYusuf could you elaborate a bit on it, since you have the most information on this atm?

@michelengelen michelengelen changed the title When using aggregations, UI of column header labels doesn't look good [data grid] When using aggregations, UI of column header labels doesn't look good Oct 9, 2024
@michelengelen
Copy link
Member

@stivluc could you re-upload the second screenshot? It seems it hasn't completed uploading it!

@michelengelen michelengelen added status: waiting for author Issue with insufficient information feature: Aggregation Related to the data grid Aggregation feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 9, 2024
@KenanYusuf
Copy link
Contributor

Hi @stivluc. We updated the header design in v7.16.0, fixing this issue as part of the changes. If you are able to upgrade, you should get an improved experience with aggregation labels.

Copy link

The issue has been inactive for 7 days and has been automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature status: waiting for author Issue with insufficient information support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/
Projects
None yet
Development

No branches or pull requests

3 participants