Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Chart example with responsive container and tooltip demo is broken #15059

Open
karolis-666 opened this issue Oct 22, 2024 · 8 comments
Open
Labels
component: charts This is the name of the generic UI component, not the React module! support: docs-feedback Feedback from documentation page

Comments

@karolis-666
Copy link

karolis-666 commented Oct 22, 2024

Related page

https://mui.com/x/react-charts/tooltip/#tooltip-position

Kind of issue

Broken demo

Issue description

Opening example in code editor displays missing files

image

Context

No response

Search keywords: chart, charts, responsive, tooltip

Search keywords:

@karolis-666 karolis-666 added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Oct 22, 2024
@oliviertassinari oliviertassinari transferred this issue from mui/material-ui Oct 22, 2024
@oliviertassinari oliviertassinari added the component: charts This is the name of the generic UI component, not the React module! label Oct 22, 2024
@alexfauquette
Copy link
Member

@karolis-666 I assume it's only broken in codesandbox because it's working when I load the page

The cause is the nested import. The files imported from the demo should not have import themself

@karolis-666
Copy link
Author

It's the only example I found that has responsive container and shows tooltip implementation for them.

Exploring source code I can't find those files which are required, so I can't simply understand logic how to implement given example in my code

@k-rajat19
Copy link
Contributor

@karolis-666 you can see them here https://github.com/mui/mui-x/tree/master/docs/data/charts/tooltip for now
@alexfauquette can we pass those as a prop in CustomTooltipPosition or is there any more appropriate fix for that ?

@alexfauquette
Copy link
Member

It's the only example I found that has a responsive container and shows tooltip implementation for them.

On my computer, I can see them in the docs. Is there something specific to your browser? Could you try in private navigation without extensions?

Capture.video.du.2024-10-23.17-24-35.mp4

@k-rajat19 Yes that would be an option. Another one would be to to copy-past then them in each file. Or restart the effort on mui/material-ui#44150

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 23, 2024
@karolis-666
Copy link
Author

These two files imported in code example are not present
image

Open this code in codesandbox or stackblitz and you'll see they are missing - app crashing
image

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 23, 2024
@alexfauquette
Copy link
Member

Thanks for clarification. Then we will restart the effort on mui/material-ui#44150 and if supporting nested imports is too much of a problem, we could fallback on the copy-paste solution

@michelengelen
Copy link
Member

should we add the mentioned PR as a fix for this @alexfauquette ?

@alexfauquette alexfauquette removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 28, 2024
@alexfauquette
Copy link
Member

I will close the issue after checking the PR and the monorepo update correctly fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! support: docs-feedback Feedback from documentation page
Projects
None yet
Development

No branches or pull requests

5 participants