Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Documentation feedback on how to use pigment-css with @mui/material and more #247

Open
kdichev opened this issue Sep 21, 2024 · 1 comment
Assignees
Labels
docs Improvements or additions to the documentation status: waiting for author Issue with insufficient information support: docs-feedback Feedback from documentation page

Comments

@kdichev
Copy link

kdichev commented Sep 21, 2024

Search keywords

docs, getting started, migrating to

Related page

https://mui.com/material-ui/migration/migrating-to-pigment-css/#installation, https://mui.com/material-ui/experimental-api/pigment-css/#manual-installation

Kind of issue

Unclear explanations

Issue description

Over the past day, I've been working on integrating @mui/material with pigment-css and encountered some issues navigating the documentation. The two pages that led to confusion were:

Migrating to Pigment CSS
Getting started with Pigment CSS

To help others avoid these issues, I consolidated my findings in this repository. I've also implemented the Getting Started guide in this pull request and the Migrating to Pigment CSS guide in this pull request.

Additionally, I highlighted several points in the documentation that could be clarified, including a few errors (like the syntax error in the Getting Started section).

Context

I was trying to implement pigment-css with @mui/material

@kdichev kdichev added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Sep 21, 2024
@zannager zannager added the docs Improvements or additions to the documentation label Sep 23, 2024
@aarongarciah
Copy link
Member

Thanks for the feedback @kdichev. We are aware of the current documentation not being ideal (e.g. Pigment CSS not having proper docs and https://mui.com/material-ui/experimental-api/pigment-css/ living in the Material UI docs). Note that the installation instructions are a bit different between https://github.com/mui/pigment-css and https://github.com/mui/material-ui because for the later we offer an adapter package (@mui/material-pigment-css).

From the issue description, it's not 100% clear what would be your expectation. Would you mind opening the corresponding PRs with the improvements you think we need to make in the relevant repositories? Namely https://github.com/mui/pigment-css and https://github.com/mui/material-ui.

@aarongarciah aarongarciah added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation status: waiting for author Issue with insufficient information support: docs-feedback Feedback from documentation page
Projects
None yet
Development

No branches or pull requests

4 participants