Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding of expandMenuActionText and collapseMenuActionText #4515

Closed
timurridjanovic opened this issue Dec 5, 2024 · 3 comments
Closed

Allow overriding of expandMenuActionText and collapseMenuActionText #4515

timurridjanovic opened this issue Dec 5, 2024 · 3 comments
Labels
duplicate This issue or pull request already exists scope: toolpad-core Abbreviated to "core"

Comments

@timurridjanovic
Copy link

timurridjanovic commented Dec 5, 2024 •
edited by github-actions bot
Loading

Summary

Allow overriding of expandMenuActionText and collapseMenuActionText for apps that aren't in english or use i18n internationalization.

Examples

image

Motivation

I need to be able to translate every english word into another language, including the Collapse menu and Expand menu on the Hamburger tooltip.

Search keywords: expandMenuActionText, collapseMenuActionText, expand, collapse
@timurridjanovic timurridjanovic added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 5, 2024
@Janpot
Copy link
Member

Janpot commented Dec 6, 2024 •
edited
Loading

I suppose we can do the same as we do in the Account. Exact names to be bikeshedded. Are you interested in contributing a PR?

@prakhargupta1 prakhargupta1 added scope: toolpad-core Abbreviated to "core" and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 17, 2024
@Janpot
Copy link
Member

Janpot commented Jan 6, 2025 •
edited
Loading

Let's concentrate these efforts on #4565

@Janpot Janpot closed this as completed Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Completed in MUI Toolpad public roadmap Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@timurridjanovic How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@Janpot Janpot added the duplicate This issue or pull request already exists label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists scope: toolpad-core Abbreviated to "core"
Projects
MUI Toolpad public roadmap
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timurridjanovic @Janpot @prakhargupta1