Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types are not well published #50

Open
vasco-santos opened this issue Mar 10, 2023 · 2 comments
Open

Types are not well published #50

vasco-santos opened this issue Mar 10, 2023 · 2 comments
Labels
P1 High: Likely tackled by core team if no one steps up

Comments

@vasco-santos
Copy link
Member

Importing this module does not get inferred types. I think we need to add them in the package.json exports

@rvagg
Copy link
Member

rvagg commented Mar 13, 2023

this package needs the multiformats@>10 treatment (#49) which also means aegir support and all of the other things we've done to the primary packages to get them publishing with the new non-cjs publishes, which also include better types exposure..

ipld/ipld#224

I don't suppose you want to tackle that @vasco-santos? https://github.com/multiformats/js-murmur3 or the ipld codecs are probably the best place to look at for the pattern we've been adopting and rolling out. This one is just far enough down the list that nobody has managed to prioritise it yet.

@vasco-santos
Copy link
Member Author

@rvagg Just created the issue to flag it and get prioritised when possible.

Currently, we actually need to use CJS because our E-IPFS lambdas were written in CJS... Upgrading with aegir treatment and non-cjs publishes will not work for us. For now, we just did the old @ts-ignore and we are fine :)

@BigLep BigLep added the P1 High: Likely tackled by core team if no one steps up label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

3 participants