From 14b674867f198f29cb1c592d9494ea7a6de8b542 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrei=20B=C4=83ncioiu?= Date: Wed, 23 Oct 2024 10:33:03 +0300 Subject: [PATCH] Fix after self-review. --- multiversx_sdk/abi/code_metadata_value.py | 2 +- multiversx_sdk/core/code_metadata.py | 2 +- multiversx_sdk/core/code_metadata_test.py | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/multiversx_sdk/abi/code_metadata_value.py b/multiversx_sdk/abi/code_metadata_value.py index b8efb11e..87ca3f92 100644 --- a/multiversx_sdk/abi/code_metadata_value.py +++ b/multiversx_sdk/abi/code_metadata_value.py @@ -30,7 +30,7 @@ def decode_top_level(self, data: bytes): def set_payload(self, value: Any): if isinstance(value, bytes): - self.value = CodeMetadata.from_bytes(value).serialize() + self.value = CodeMetadata.new_from_bytes(value).serialize() elif isinstance(value, CodeMetadata): self.value = value.serialize() else: diff --git a/multiversx_sdk/core/code_metadata.py b/multiversx_sdk/core/code_metadata.py index f7a08f7b..dc5f1ac7 100644 --- a/multiversx_sdk/core/code_metadata.py +++ b/multiversx_sdk/core/code_metadata.py @@ -23,7 +23,7 @@ def __init__(self, upgradeable: bool = True, readable: bool = True, payable: boo self.payable_by_contract = payable_by_contract @classmethod - def from_bytes(cls, data: bytes) -> "CodeMetadata": + def new_from_bytes(cls, data: bytes) -> "CodeMetadata": if len(data) != CODE_METADATA_LENGTH: raise ValueError(f"code metadata buffer has length {len(data)}, expected {CODE_METADATA_LENGTH}") diff --git a/multiversx_sdk/core/code_metadata_test.py b/multiversx_sdk/core/code_metadata_test.py index 33609c76..0df0424a 100644 --- a/multiversx_sdk/core/code_metadata_test.py +++ b/multiversx_sdk/core/code_metadata_test.py @@ -5,33 +5,33 @@ from multiversx_sdk.core.code_metadata import CodeMetadata -def test_code_metadata_from_bytes(): - metadata = CodeMetadata.from_bytes(bytes([0x05, 0x00])) +def test_code_metadata_new_from_bytes(): + metadata = CodeMetadata.new_from_bytes(bytes([0x05, 0x00])) assert metadata.upgradeable == True assert metadata.readable == True assert metadata.payable == False assert metadata.payable_by_contract == False - metadata = CodeMetadata.from_bytes(bytes([0x05, 0x06])) + metadata = CodeMetadata.new_from_bytes(bytes([0x05, 0x06])) assert metadata.upgradeable == True assert metadata.readable == True assert metadata.payable == True assert metadata.payable_by_contract == True - metadata = CodeMetadata.from_bytes(bytes([0x05, 0x00])) + metadata = CodeMetadata.new_from_bytes(bytes([0x05, 0x00])) assert metadata.upgradeable == True assert metadata.readable == True assert metadata.payable == False assert metadata.payable_by_contract == False - metadata = CodeMetadata.from_bytes(bytes([0x00, 0x00])) + metadata = CodeMetadata.new_from_bytes(bytes([0x00, 0x00])) assert metadata.upgradeable == False assert metadata.readable == False assert metadata.payable == False assert metadata.payable_by_contract == False with pytest.raises(ValueError, match="code metadata buffer has length 4, expected 2"): - CodeMetadata.from_bytes(bytes([0x00, 0x01, 0x02, 0x03])) + CodeMetadata.new_from_bytes(bytes([0x00, 0x01, 0x02, 0x03])) def test_code_metadata_serialize():