Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo, Command chapter. #366

Open
Layarion opened this issue Aug 13, 2021 · 2 comments
Open

Typo, Command chapter. #366

Layarion opened this issue Aug 13, 2021 · 2 comments

Comments

@Layarion
Copy link

Original text: we need to turn those direct calls to jump() and fireGun() into something that we can swap out.

"direct calls to jump" needs to be changed to "direct calls of" or perhaps "direct calls for"

@JensB-tech
Copy link

This is incorrect. "Direct calls to" is perfectly valid programming phrasing. He is talking about particular method calls. When we talk about method and function calls, we say that a call is a call to a particular function. So no, it is not a typo and it doesn't need to be changed.

@Layarion
Copy link
Author

Layarion commented Sep 5, 2021

This is incorrect. "Direct calls to" is perfectly valid programming phrasing. He is talking about particular method calls. When we talk about method and function calls, we say that a call is a call to a particular function. So no, it is not a typo and it doesn't need to be changed.

hmm it makes sense after you explained it, but you need to consider the person reading this might not have that specific "programmer" lingo baked into them. This targets people who already don't know enough that they need patterns spelled out to them, people like me, and I even thinking it's a typo kinda proves that point already (and i am a programmer, so i mean - who are you really saying that "to" knowledge is for?). Is your target audience only for programmers who know how a programmer thinks? or for a wider audience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants