From 24a2088efb02fe7a30ea18f022f1bbd97f271e79 Mon Sep 17 00:00:00 2001 From: Casper Jeukendrup <48658420+cbjeukendrup@users.noreply.github.com> Date: Wed, 1 May 2024 00:03:28 +0200 Subject: [PATCH] Revert "Set PopupView as parent of PopupWindow_QQuickView" This reverts commit 09200b3cc1d3f8e6b930b9616284f912a22f76f2. That commit did fix a real problem (and a memory leak), but that problem should not occur anymore because of d18f9b3b43784db8164ee7204d8a6f470d9d68d6, and the commit caused other problems that are not quite trivial (#22640 and #22641). Therefore, we'll revert this commit for now. --- src/framework/uicomponents/view/popupview.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/framework/uicomponents/view/popupview.cpp b/src/framework/uicomponents/view/popupview.cpp index 1f3f0254a741a..41bb4c8d7fed1 100644 --- a/src/framework/uicomponents/view/popupview.cpp +++ b/src/framework/uicomponents/view/popupview.cpp @@ -133,7 +133,7 @@ void PopupView::init() return; } - m_window = new PopupWindow_QQuickView(this); + m_window = new PopupWindow_QQuickView(); m_window->init(engine, isDialog(), frameless()); m_window->setOnHidden([this]() { onHidden(); }); m_window->setContent(m_component, m_contentItem);