Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with buttons tooltips displayed strings #26198

Open
FrancRos31 opened this issue Jan 21, 2025 · 6 comments
Open

Issue with buttons tooltips displayed strings #26198

FrancRos31 opened this issue Jan 21, 2025 · 6 comments
Assignees
Labels
community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute

Comments

@FrancRos31
Copy link

FrancRos31 commented Jan 21, 2025

Image
These are the buttons in question.

Open and run the program empty, hover above the buttons with the mouse: the three tooltips display strings 4068-4070, with the word STAVES.

Image
righi=staves

Then, open a grand staff score, select the only instrument in the panel (Piano) and check again the same tooltips: now, they display strings 4072-4074, with the word INSTRUMENTS.

Image
strumenti=instruments

Expected behaviour: the tooltips always display the same set of strings.

What is the latest version of MuseScore Studio where this issue is present?

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.4-243461245, revision: github-musescore-musescore-2232670

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Jan 22, 2025

For the empty state, I'd agree that saying instruments makes more sense. But when you expand the row of an instrument (by clicking the little triangle at the left), you actually see rows for the staves of that instrument. So when one of those rows is selected, the tooltip should actually say staves.

Probably trivial to fix; for whoever wants to give it a go, search for isInstrumentSelected. Probably a good idea to replace that with a new property called isStaffSelected, which is false in the empty state.

@cbjeukendrup cbjeukendrup added good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute community Issues particularly suitable for community contributors to work on labels Jan 22, 2025
@jvleta
Copy link

jvleta commented Jan 22, 2025

If no one has claimed this issue yet, I would like to take a stab at it :)

@oktophonie oktophonie moved this from Available to Tentatively in progress in Community Projects Jan 22, 2025
@FrancRos31

This comment has been minimized.

@jvleta
Copy link

jvleta commented Jan 27, 2025

Apologies for the delay on this. I am having a difficult time reproing on macOS. I am able to build the app, but the tooltips are not rendering as expected. I am using QT 6.7.3 installed with homebrew. Should I be using a different version?

@cbjeukendrup
Copy link
Contributor

You need Qt 6.2.4 for the time being; see https://github.com/musescore/MuseScore/wiki/Install-Qt-and-Qt-Creator. Newer versions indeed cause problems with tooltips.

@FrancRos31
Copy link
Author

FrancRos31 commented Jan 27, 2025

@jvleta @cbjeukendrup

There's another instance of this issue in the tool bar:

  1. (right after running MS empty) strings 1169 and 1828
    Image

  2. (after opening a score) strings 1264 and 1831
    Image

  3. (after closing the previous score)
    Image

Why does 3 show the strings of 2? In 3 there's no open score, it should show the strings of 1

I'm gonna edit the title. This is not a translation-related issue.

@FrancRos31 FrancRos31 changed the title Issue with buttons tooltips translation in the Instruments panel (Italian version) Issue with buttons tooltips translation in the Instruments panel Jan 27, 2025
@FrancRos31 FrancRos31 changed the title Issue with buttons tooltips translation in the Instruments panel Issue with buttons tooltips in the Instruments panel Jan 27, 2025
@FrancRos31 FrancRos31 changed the title Issue with buttons tooltips in the Instruments panel Issue with buttons tooltips displayed strings Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute
Projects
Status: Tentatively in progress
Development

No branches or pull requests

3 participants