Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tech debt introduced by #24944 #26800

Open
3 tasks
cbjeukendrup opened this issue Feb 27, 2025 · 0 comments
Open
3 tasks

Fix the tech debt introduced by #24944 #26800

cbjeukendrup opened this issue Feb 27, 2025 · 0 comments

Comments

@cbjeukendrup
Copy link
Contributor

PR #24944 was merged to keep everyone happy, except ourselves, because it introduced quite some tech debt.

  • Remove staff index awareness from FluidSequencer
  • Remove MIDI output awareness from FluidSynth
    (it was already there, but that PR made it even bigger)
    (see also Show playing notes on the piano keyboard #21874, which does some work in that direction)
  • Clean up MidiEvent class
    The PR revealed that this class is mixing and confusing MIDI 1.0 and 2.0; it added some patchwork to fix that, but there seems to be room for a more structured solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant