Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase grad slightly wrong when run in multiple MPI jobs #38

Open
musoke opened this issue Mar 16, 2021 · 0 comments
Open

Phase grad slightly wrong when run in multiple MPI jobs #38

musoke opened this issue Mar 16, 2021 · 0 comments

Comments

@musoke
Copy link
Owner

musoke commented Mar 16, 2021 •
edited
Loading

The phase gradient is not calculated on the boundary between pencils. Typically this is a very small subset of the grid, so not a problem.
musoke added a commit that referenced this issue Mar 16, 2021
@musoke
MPI: Add boilerplate phase grid checks
3a91a63 
The normal phase grid checks don't work for a PencilArray, so disable
them for now by adding an implementation that gives a warning and
returns 0.

Related: #38
musoke added a commit that referenced this issue Mar 16, 2021
@musoke
MPI: Add boilerplate phase grid checks
fe339a8 
The normal phase grid checks don't work for a PencilArray, so disable
them for now by adding an implementation that gives a warning and
returns 0.

Related: #38
musoke added a commit that referenced this issue Apr 1, 2021
@musoke
MPI: Add boilerplate phase grid checks
1b895ed 
The normal phase grid checks don't work for a PencilArray, so disable
them for now by adding an implementation that gives a warning and
returns 0.

Related: #38
musoke added a commit that referenced this issue Apr 19, 2021
@musoke
fix: Compute phase diff for PencilGrids
b96b6d7 
TODO: compute correct diff at boundaries.

Related: #38
musoke added a commit that referenced this issue Apr 19, 2021
@musoke
fix: Compute phase diff for PencilGrids
07a66dc 
Compute the phase difference for PecilGrids a single pencil at a time.
Set the diff to 0 on boundaries.

TODO: compute correct diff at boundaries.
Either:
- explicit internode communication of values at boundaries
- align pencils with direction of diff before computing

Related: #38
@musoke musoke changed the title Phase grad broken when run in multiple MPI jobs Phase grad slightly wrong when run in multiple MPI jobs Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@musoke