Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karibu-testing to support LitRenderer #183

Open
vlipovetskii opened this issue Jan 12, 2025 · 1 comment
Open

Update karibu-testing to support LitRenderer #183

vlipovetskii opened this issue Jan 12, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@vlipovetskii
Copy link

No description provided.

@mvysny mvysny self-assigned this Jan 13, 2025
@mvysny mvysny added the enhancement New feature or request label Jan 13, 2025
@mvysny
Copy link
Owner

mvysny commented Jan 13, 2025

Karibu-Testing currently does have a simple support for LitRenderers: for example:

LitRenderer.of<Int>("<div>\${item.foo}</div>")
                    .withProperty("foo") { "Item #$it" }

is rendered as Item #25 (for an integer row value of '25').

This is a good balance between Karibu not supporting LitRenderers at all, and dumping all of the HTML, making the Grid tests too chatty and bloated.

However, if you'd like to have this algorithm changed, please list a counter-example where this simple algorithm doesn't do a good job.

@mvysny mvysny added the question Further information is requested label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants