From 87e216f038774fd989aba497726d630d61610811 Mon Sep 17 00:00:00 2001 From: Marc Wouts Date: Tue, 27 Nov 2018 01:52:42 +0100 Subject: [PATCH] pylint --- jupytext/cli.py | 14 +++++++------- jupytext/contentsmanager.py | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/jupytext/cli.py b/jupytext/cli.py index 01c7395a9..e1702a9e2 100644 --- a/jupytext/cli.py +++ b/jupytext/cli.py @@ -140,7 +140,7 @@ def system(*args, **kwargs): """Execute the given bash command""" kwargs.setdefault('stdout', subprocess.PIPE) proc = subprocess.Popen(args, **kwargs) - out, err = proc.communicate() + out, _ = proc.communicate() return out @@ -186,14 +186,14 @@ def canonize_format(format_or_ext, file_path=None): return {'notebook': 'ipynb', 'markdown': 'md', 'rmarkdown': 'Rmd'}[format_or_ext] -def str2bool(input): +def str2bool(value): """Parse Yes/No/Default string https://stackoverflow.com/questions/15008758/parsing-boolean-values-with-argparse""" - if input.lower() in ('yes', 'true', 't', 'y', '1'): + if value.lower() in ('yes', 'true', 't', 'y', '1'): return True - if input.lower() in ('no', 'false', 'f', 'n', '0'): + if value.lower() in ('no', 'false', 'f', 'n', '0'): return False - if input.lower() in ('d', 'default', ''): + if value.lower() in ('d', 'default', ''): return None raise argparse.ArgumentTypeError('Expected: (Y)es/(T)rue/(N)o/(F)alse/(D)efault') @@ -222,8 +222,8 @@ def cli_jupytext(args=None): 'is provided , but then the --from field is mandatory', nargs='*') parser.add_argument('--pre-commit', action='store_true', - help="""Run Jupytext on the ipynb files in the git index. -Create a pre-commit hook with: + help="""Run Jupytext on the ipynb files in the git index. +Create a pre-commit hook with: echo '#!/bin/sh jupytext --to py:light --pre-commit' > .git/hooks/pre-commit diff --git a/jupytext/contentsmanager.py b/jupytext/contentsmanager.py index beac92568..38b20d10a 100644 --- a/jupytext/contentsmanager.py +++ b/jupytext/contentsmanager.py @@ -28,9 +28,9 @@ def kernelspec_from_language(language): """Return the kernel specification for the first kernel with a matching language""" try: for name in find_kernel_specs(): - ks = get_kernel_spec(name) - if ks.language == language or (language == 'c++' and ks.language.startswith('C++')): - return {'name': name, 'language': language, 'display_name': ks.display_name} + kernel_specs = get_kernel_spec(name) + if kernel_specs.language == language or (language == 'c++' and kernel_specs.language.startswith('C++')): + return {'name': name, 'language': language, 'display_name': kernel_specs.display_name} except (KeyError, ValueError): pass return None