Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't generate 2 empty lines within a statement #2878

Closed
manticore-projects opened this issue May 19, 2023 · 4 comments
Closed

Please don't generate 2 empty lines within a statement #2878

manticore-projects opened this issue May 19, 2023 · 4 comments

Comments

@manticore-projects
Copy link

manticore-projects commented May 19, 2023

Greetings!

Starting with JSQLParser 4.6, two empty lines .*\n\n\n terminate a statement.
(And I still will need a good argument why anyone would need 2 empty rows within one statement.)

select 1 from dual


select 2 from dual

gives 2 statements (without typing semicolons ;)

I will appreciate your consideration, since we receive reports about MyBatis' auto-generated statements. Thank you.

@harawata
Copy link
Member

Hello @manticore-projects ,

MyBatis itself does not generate any SQL automatically.
I have never used JSQLParser, but if it generates the SQL, you should report it on their tracker.

Closing as : not a MyBatis issue

@manticore-projects
Copy link
Author

Greetings!

Thank you for responding. If it is not about MyBatis then why does JSQLParser receive reports from MyBatis, e. g. baomidou/mybatis-plus#5345

I come from the JSQLParser's end and only try to understand the architecture.

@harawata
Copy link
Member

@manticore-projects ,

I'm sorry for not being helpful, but mybatis-plus is a third party project (it belongs to a different organization, as you can see) and we don't know what it does or how it works.

@manticore-projects
Copy link
Author

Oh! Apologies, I was not aware that it is not the same thing! Sorry for bothering you.
Thank you for clarifying and cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants