Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot modify speakers in ACP when slug is not alphanumeric ASCII #511

Open
wfdd opened this issue Feb 4, 2016 · 2 comments
Open

Cannot modify speakers in ACP when slug is not alphanumeric ASCII #511

wfdd opened this issue Feb 4, 2016 · 2 comments

Comments

@wfdd
Copy link

wfdd commented Feb 4, 2016

Steps to reproduce:

  1. Create a new speaker whose name includes non-ASCII characters via /speaker/add; or import speakers from Popolo JSON
  2. In the ACP, under 'Speakers', click on the speaker to modify
  3. Press 'Save'

Django warns, "Enter a valid 'slug' consisting of letters, numbers, underscores or hyphens".

@wfdd
Copy link
Author

wfdd commented Feb 4, 2016

On further inspection, this probably needs to be fixed in mysociety/django-sluggable; mozilla/unicode-slugify#10 may be of relevance.

@dracos
Copy link
Member

dracos commented Feb 5, 2016

Thanks; I see that Django 1.9 added an allow_unicode argument to SlugField which would fix this: https://docs.djangoproject.com/en/1.9/releases/1.9/ – we'll implement something like the issue you link to, to continue supporting 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants