Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gossip.join() API is dangerous #2865

Open
link2xt opened this issue Oct 29, 2024 · 0 comments
Open

Gossip.join() API is dangerous #2865

link2xt opened this issue Oct 29, 2024 · 0 comments

Comments

@link2xt
Copy link
Contributor

link2xt commented Oct 29, 2024 •
edited
Loading

If you want to break compatibility at some point, would be nice to deprecate https://docs.rs/iroh-gossip/0.27.0/iroh_gossip/net/struct.Gossip.html#method.join

It calls .joined().await internally which I would rather call explicitly. Otherwise it is too easy to block the whole app or forget the timeout: deltachat/deltachat-core-rust#6110
@divagant-martian divagant-martian changed the title Gossip.join() API is dangerouns Gossip.join() API is dangerous Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
iroh
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@link2xt