From 45abab5b45add1060caa5abfc2b5f96dbf85a96c Mon Sep 17 00:00:00 2001
From: n0099 <n@n0099.net>
Date: Wed, 1 May 2024 00:26:21 +0800
Subject: [PATCH] * now will only enable Roslyn analyzer when building
 configuration is `Release` instead of `Debug`, also changed
 `<TreatWarningsAsErrors>` in `Directory.Build.props` * update NuGet packages
 @ c#/shared

* now will build under configuration `Release` @ .github/workflows/c#.yml
---
 .github/workflows/c#.yml     |  2 +-
 c#/Directory.Build.props     |  2 ++
 c#/shared/packages.lock.json | 18 +++++++++---------
 c#/shared/tbm.Shared.csproj  |  6 +++---
 4 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/c#.yml b/.github/workflows/c#.yml
index 7fb17d3a..04e66017 100644
--- a/.github/workflows/c#.yml
+++ b/.github/workflows/c#.yml
@@ -17,7 +17,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/c#
-      - run: dotnet build --no-restore -c Debug ${{ matrix.project }}
+      - run: dotnet build --no-restore -c Release ${{ matrix.project }}
 
   ReSharper:
     runs-on: ubuntu-latest
diff --git a/c#/Directory.Build.props b/c#/Directory.Build.props
index c684f1c8..4fe29c92 100644
--- a/c#/Directory.Build.props
+++ b/c#/Directory.Build.props
@@ -10,6 +10,8 @@
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
         <AnalysisMode>Recommended</AnalysisMode>
         <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Configuration)' == 'Release'">
         <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
     <ItemGroup>
diff --git a/c#/shared/packages.lock.json b/c#/shared/packages.lock.json
index dcf484ea..385fd7cf 100644
--- a/c#/shared/packages.lock.json
+++ b/c#/shared/packages.lock.json
@@ -58,9 +58,9 @@
       },
       "Meziantou.Analyzer": {
         "type": "Direct",
-        "requested": "[2.0.149, )",
-        "resolved": "2.0.149",
-        "contentHash": "nJaiWMp6AlosBpl3sJO/frbqiImPBHodaJpcwlA/ez3zwjj9ZF4oeH0tWHSRFW8+e5mJMswlc3Kwl8DFskVOCg=="
+        "requested": "[2.0.150, )",
+        "resolved": "2.0.150",
+        "contentHash": "rXKN4/Cf58Pv7uUWk4wcZtY+J9mve6wA1BHGYAf9SlpmiayA5fJ4wK2lflIwAkVo8n8HyNCeY3Ej4jwCdLk5nA=="
       },
       "Microsoft.CodeAnalysis.NetAnalyzers": {
         "type": "Direct",
@@ -118,13 +118,13 @@
       },
       "NLog.Extensions.Logging": {
         "type": "Direct",
-        "requested": "[5.3.8, )",
-        "resolved": "5.3.8",
-        "contentHash": "6VD0lyeokWltL6j8lO7mS7v7lbuO/qn0F7kdvhKhEx1JvFyD39nzohOK3JvkVh4Nn3mrcMDCyDxvTvmiW55jQg==",
+        "requested": "[5.3.9, )",
+        "resolved": "5.3.9",
+        "contentHash": "NiZfTr1cZeEycW8OFOGQw4dTkxYCD3VnUHLDn/Fr+ALGOICLnPyRWFlLWGz01jq7BcgDdFmTWbCpbXNhXFu3DQ==",
         "dependencies": {
           "Microsoft.Extensions.Configuration.Abstractions": "8.0.0",
           "Microsoft.Extensions.Logging": "8.0.0",
-          "NLog": "5.2.8"
+          "NLog": "5.3.1"
         }
       },
       "Npgsql.EntityFrameworkCore.PostgreSQL": {
@@ -463,8 +463,8 @@
       },
       "NLog": {
         "type": "Transitive",
-        "resolved": "5.2.8",
-        "contentHash": "jAIELkWBs1CXFPp986KSGpDFQZHCFccO+LMbKBTTNm42KifaI1mYzFMFQQfuGmGMTrCx0TFPhDjHDE4cLAZWiQ=="
+        "resolved": "5.3.1",
+        "contentHash": "P5ipL1rWveuZYLff++q5QDNJST0KW3z42Y/VkXUxURELuONAg9nxYziY0J9nrwQYKr18qtqNqjGYBTFxABc9kg=="
       },
       "Npgsql": {
         "type": "Transitive",
diff --git a/c#/shared/tbm.Shared.csproj b/c#/shared/tbm.Shared.csproj
index 26c79fda..7657c830 100644
--- a/c#/shared/tbm.Shared.csproj
+++ b/c#/shared/tbm.Shared.csproj
@@ -6,19 +6,19 @@
         <PackageReference Include="EFCore.NamingConventions" Version="8.0.3" />
         <PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.4" />
         <PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
-        <PackageReference Include="NLog.Extensions.Logging" Version="5.3.8" />
+        <PackageReference Include="NLog.Extensions.Logging" Version="5.3.9" />
         <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="8.0.2" />
         <PackageReference Include="SuperLinq" Version="6.0.0" />
     </ItemGroup>
     <Choose>
-        <When Condition="'$(Configuration)' == 'Debug'">
+        <When Condition="'$(Configuration)' == 'Release'">
             <ItemGroup>
                 <!-- https://stackoverflow.com/questions/73180516/if-a-nuget-specifies-privateassets-all-why-specify-includeassets -->
                 <!-- enable PrivateAssets="All" will prevent analyzers working on other project that has <PackageReference> to this -->
                 <PackageReference ExcludeAssets="compile" Include="codecracker.CSharp" Version="1.1.0" />
                 <PackageReference ExcludeAssets="compile" Include="CSharpGuidelinesAnalyzer" Version="3.8.5" />
                 <PackageReference ExcludeAssets="compile" Include="IDisposableAnalyzers" Version="4.0.7" />
-                <PackageReference ExcludeAssets="compile" Include="Meziantou.Analyzer" Version="2.0.149" />
+                <PackageReference ExcludeAssets="compile" Include="Meziantou.Analyzer" Version="2.0.150" />
                 <PackageReference ExcludeAssets="compile" Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0" />
                 <PackageReference ExcludeAssets="compile" Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.9.28" />
                 <PackageReference ExcludeAssets="compile" Include="Roslynator.Analyzers" Version="4.12.2" />