Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using status to keep track of the archive as opposed to a separate collection #71

Open
kungpaogao opened this issue Jul 26, 2020 · 0 comments
Assignees
Labels
code Code fixes and improvements later Feature or request for later

Comments

@kungpaogao
Copy link
Member

Honestly, it makes no sense to create a separate collection now that I think about it.

This should be addressed in a big refactor update that includes #12. This can be addressed later in the dev cycle? Or now to avoid a cascading amount of changes?

Pros of updating:

  • cleaner code/logic for checking across all furniture
  • potentially cleaner code for front end since you don't have to have 2 namespaces for archive/inventory - need to think about this though

Cons:

  • time - rewriting stuff is not fun
@kungpaogao kungpaogao added later Feature or request for later code Code fixes and improvements labels Jul 26, 2020
@kungpaogao kungpaogao self-assigned this Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code fixes and improvements later Feature or request for later
Projects
None yet
Development

No branches or pull requests

1 participant