Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Serial Channels not cleaned up when server sockets close #7

Open
n6il opened this issue May 11, 2020 · 0 comments
Open

Virtual Serial Channels not cleaned up when server sockets close #7

n6il opened this issue May 11, 2020 · 0 comments
Milestone
v0.5d

Comments

@n6il
Copy link
Owner

n6il commented May 11, 2020 •
edited
Loading

If a client (such as an emulator) is connected over a socket and is suddenly terminated Virtual Serial channels may remain open. If the client is restarted there may be issues with ports that have remained open.
n6il added a commit that referenced this issue May 11, 2020
@n6il
(issue #7) Do some clean up when server sockets close
4fb0b24 
Clients connecting to pyDriveWire over a socket can terminate suddenly.  If
the clients opened Virtual Serial channels those can remain open and may
cause problems when the client reconnects.  The fix adds a callback
mechanism to DWServerSocket and DWSimpleSocket when the connection closes.
The callback is set to the Server's cmdInit method.  This resets all the
open disk files and closes all of the Virtual Serial channels.
@n6il n6il added this to the v0.5d milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5d
Development

No branches or pull requests
1 participant
@n6il