Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log parameters of ClientConfig will not take effect at all. #747

Open
wangjian-pg opened this issue Apr 18, 2024 · 2 comments
Open

Log parameters of ClientConfig will not take effect at all. #747

wangjian-pg opened this issue Apr 18, 2024 · 2 comments

Comments

@wangjian-pg
Copy link
Contributor

What version of nacos-sdk-go are you using?

The master branch of the repo.(commit ID: 6dd8997)

After merging #722, since the logger package's init function already sets the global logger to a non-nil value, the common.logger.InitLogger function will always return prematurely, making the logging parameter ClientConfig have no effect at all.

Please check the following code lines:

We may need to review the code more carefully before accepting the PR.

@binbin0325
Copy link
Member

Can you submit pr to fix it

@dingyang666
Copy link
Contributor

Can you submit pr to fix it

I also noticed this issue and submitted a PR to fix it.
PTAL #759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants