Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini_magick removed deprecated Image#mime_type #100

Open
alexandermeindl opened this issue Oct 6, 2024 · 0 comments
Open

mini_magick removed deprecated Image#mime_type #100

alexandermeindl opened this issue Oct 6, 2024 · 0 comments

Comments

@alexandermeindl
Copy link

mini_magick removed deprecated Image#mime_type with version 5, see https://github.com/minimagick/minimagick/releases/tag/v5.0.0

With mini_magick v4.x I got the following warning with rbpdf:

pdf.image image_path
[MiniMagick] MiniMagick::Image#mime_type has been deprecated, because it wasn't returning correct result for all formats ImageMagick supports. Unfortunately, returning the correct MIME type would be very slow, because it would require ImageMagick to read the whole file. It's better to use Marcel and MimeMagic gems, which are able to determine the MIME type just from the image header.

With mini_magick v5.x I get the following error:

pdf.image image_path
eval error: `mogrify -mime-type /var/folders/jh/1wzz7k914zzc5vmf5hkg8tjm0000gn/T/mini_magick20241006-6457-7wup66.png20241006-6457-xtflju` failed with status: 1 and error:
mogrify: unrecognized option `-mime-type' @ error/mogrify.c/MogrifyImageCommand/5564.
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/mini_magick-5.0.1/lib/mini_magick/shell.rb:20:in `run'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/mini_magick-5.0.1/lib/mini_magick/tool.rb:85:in `call'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/mini_magick-5.0.1/lib/mini_magick/tool.rb:35:in `new'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/mini_magick-5.0.1/lib/mini_magick.rb:27:in `block (2 levels) in <module:MiniMagick>'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/mini_magick-5.0.1/lib/mini_magick/image.rb:566:in `mogrify'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/mini_magick-5.0.1/lib/mini_magick/image.rb:463:in `method_missing'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/rbpdf-1.21.3/lib/core/mini_magick.rb:59:in `getimagesize'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/rbpdf-1.21.3/lib/rbpdf.rb:5150:in `parsejpeg'
  /Users/alex/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/rbpdf-1.21.3/lib/rbpdf.rb:5053:in `Image'

Redmine master switched to latest mini_magick version. Now with Redmine plugins, which adds images to PDF export, I got this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant