Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove element selectors #7

Open
tsargent opened this issue Apr 7, 2017 · 2 comments
Open

remove element selectors #7

tsargent opened this issue Apr 7, 2017 · 2 comments

Comments

@tsargent
Copy link
Contributor

tsargent commented Apr 7, 2017

I think @lovisaNamely and @HipsterBrown have been advocating this, but just an issue to keep it on our radar. Should we remove element selectors like these?
https://github.com/namely/namely-ui-css/blob/master/scss/elements/_typography.scss#L44-L49

... leaving us with just the .class selectors?

@HipsterBrown
Copy link
Contributor

I was focused more more input fields and form selectors, which is where a lot of the strict overrides tend to happen. However, I could see where removing all element selectors helps with consistent usage of the utilities.

@lovisaNamely
Copy link
Contributor

lovisaNamely commented Apr 7, 2017

I want to remove all of those element selectors, yes 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants