Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: merge ProjectVersioner\Reader\Composer and ProjectVersioner\Reader\ComposerPackage into one reader #1

Open
ivarb opened this issue Mar 30, 2015 · 0 comments

Comments

@ivarb
Copy link
Contributor

ivarb commented Mar 30, 2015

I think ProjectVersioner\Reader\Composer and ProjectVersioner\Reader\ComposerPackage could easily be merged together, where an optional constructor argument would supply a specific package version to read. If omitted, a version over all packages (i.e. composer.lock hash) would be returned.

This leaves more room for a Composer reader that reads the composer.json file and returns the version value if defined in that file. Since version it's optional for composer.json and never present in composer.lock you cannot rely on it, but in most cases it will be the version one wants to retrieve.

naneau pushed a commit that referenced this issue Apr 8, 2015
Update AB remote with latest changes from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant