Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

Test multiple identical remarks (for #277) #280

Closed

Conversation

ogenstad
Copy link
Contributor

Another test for #277 which uses multiple identical remarks. Don't know how common this would be, only thinking about scenarios where the differ might be struggling.

@dbarrosop
Copy link
Member

dbarrosop commented Jul 16, 2017

Oh, I see what you did here. Goddamn it, you broke it!!!

I will think about it but I'd say it's fine if the diff shows only:

  ip access-list extended TEST-ACL
+   remark # DENY
+   deny  ip any any

As it's the case. The solution might be too ugly for little gain as this is mostly aesthetics, the unreported command actually doesn't give you any useful information and I am sure nobody would miss it :P

Anyway, will scratch my head around this for a while...

@ogenstad
Copy link
Contributor Author

Mission accomplished ;)

But yeah, I agree with you. Don't know if there's a real problem here, just a strange thing which might pop up sometime. Can't think of any other scenario which would look like this one.

@dbarrosop
Copy link
Member

Closing this one for the time being.

@dbarrosop dbarrosop closed this Jul 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants