Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent versioning #87

Open
scisme opened this issue Nov 15, 2018 · 2 comments
Open

Consistent versioning #87

scisme opened this issue Nov 15, 2018 · 2 comments

Comments

@scisme
Copy link
Contributor

scisme commented Nov 15, 2018

To avoid confusion we should have a consistent versioning and set CFBundleVersion to number of commits and CFBundleShortVersionString to the current tag, as described here:

https://www.mokacoding.com/blog/automatic-xcode-versioning-with-git/

scisme pushed a commit to scisme/WiredClient that referenced this issue Nov 15, 2018
@nark
Copy link
Owner

nark commented Nov 16, 2018

Ok, what I did from the repository side is:

  1. create tag when we want to release a binary (a Debug or real Release version)
  2. the tag is composed of version number + build number, as follow: 2.4-352
  3. then use GitHub Release feature to expose it to the world

You can see an exemple here: https://github.com/nark/WiredClient/releases

@scisme
Copy link
Contributor Author

scisme commented Nov 19, 2018

The point of using the script is to have a consistent build number that is derived from the number of commits from the git repo. 352 in this case is just a number you increase now and it doesn't really relate to anything?

So my suggestion is to just keep the tag as 2.4 and perhaps have one for the "real" release versions and the other could perhaps be together with some CI solution to have nightly builds like morris used to have?

So there could perhaps be a 2.4 (Release) tag and a 2.4.1 (Nigthly) tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants