From 61ea9de164ba9965bc6be8d31eeb5efb77daca77 Mon Sep 17 00:00:00 2001 From: Marco Gorelli <33491632+MarcoGorelli@users.noreply.github.com> Date: Tue, 12 Nov 2024 12:53:16 +0000 Subject: [PATCH] fixup --- tests/frame/select_test.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/frame/select_test.py b/tests/frame/select_test.py index 38f7677bc..52c2a71fb 100644 --- a/tests/frame/select_test.py +++ b/tests/frame/select_test.py @@ -4,6 +4,7 @@ import pytest import narwhals.stable.v1 as nw +from tests.utils import PANDAS_VERSION from tests.utils import Constructor from tests.utils import assert_equal_data @@ -34,7 +35,10 @@ def test_non_string_select_invalid() -> None: nw.to_native(df.select(0)) # type: ignore[arg-type] -def test_select_boolean_cols() -> None: +def test_select_boolean_cols(request: pytest.FixtureRequest) -> None: + if PANDAS_VERSION < (1, 1): + # bug in old pandas + request.applymarker(pytest.mark.xfail) df = nw.from_native(pd.DataFrame({True: [1, 2], False: [3, 4]}), eager_only=True) result = df.group_by(True).agg(nw.col(False).max()) # type: ignore[arg-type]# noqa: FBT003 assert_equal_data(result.to_dict(as_series=False), {True: [1, 2]}) # type: ignore[dict-item]