Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: join_where? #1861

Open
MarcoGorelli opened this issue Jan 24, 2025 · 2 comments
Open

feat: join_where? #1861

MarcoGorelli opened this issue Jan 24, 2025 · 2 comments
Labels
blocked enhancement New feature or request

Comments

@MarcoGorelli
Copy link
Member

Might join_where be in-scope? I think that for Polars / DuckDB / PySpark / Ibis it should be doable, and very nice-to-have. I don't think pandas / pyarrow have equivalents, but maybe that's OK - for most of our API, it's other libraries that raise NotImplementedError, maybe it's OK if in some cases it's pandas / pyarrow that do so 😄

@camriddell this seems like it may be up your street, do you have any thoughts?

@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Jan 24, 2025
@camriddell
Copy link
Contributor

@MarcoGorelli checking to see if this is still in-scope with the feature slow down.

IMO, join_where sounds like it would be great to support- can probably get the API for those that implement it pretty quickly and even add in pandas/pyarrow support via a cross join + filter?

@MarcoGorelli
Copy link
Member Author

thanks for looking into this!

just noticed that this still marked as experimental and unstable in polars:

This functionality is experimental. It may be changed at any point without it being considered a breaking change.

maybe we should hold off until it stabilises in polars? which, I expect, won't be in too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants