Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for contributions: Ibis support #1886

Open
MarcoGorelli opened this issue Jan 28, 2025 · 2 comments
Open

Request for contributions: Ibis support #1886

MarcoGorelli opened this issue Jan 28, 2025 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MarcoGorelli
Copy link
Member

I'm quite confident about how we're supporting PySpark DuckDB, and I think it's time to support Ibis too.

I think that it can probably mostly be supported by just copy-and-pasting what's in narwhals/_duckdb and making some API adjustments. I don't think any major refactor or anything like that would be required.

Anyone fancy trying this? If so, contributions would be welcome! You can start by reading the contributing guide, and reaching out to us here or on Discord if anything trips you up
@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Jan 28, 2025
@FBruzzesi FBruzzesi added the help wanted Extra attention is needed label Jan 29, 2025
@rwhitten577
Copy link

I can have a go at it. I have my own Narwhals Ibis implementation built out so will just need to update and make sure it meets any recent changes/patterns in Narwhals.

@MarcoGorelli
Copy link
Member Author

amazing, thanks @rwhitten577 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwhitten577 @MarcoGorelli @FBruzzesi