Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: factor out PolarsDataFrame #461

Closed
MarcoGorelli opened this issue Jul 9, 2024 · 1 comment
Closed

Refactor: factor out PolarsDataFrame #461

MarcoGorelli opened this issue Jul 9, 2024 · 1 comment
Labels

Comments

@MarcoGorelli
Copy link
Member

The current structure is:

.
└── narwhals
    ├── _arrow
    ├── _pandas_like
    └── stable

and differences between different Polars versions are handled directly in narwhals.dataframe.py and narwhals.series.py. I think it'd be cleaner if there was an extra _polars directory, i.e.:

.
└── narwhals
    ├── _arrow
    ├── _pandas_like
    ├── _polars
    └── stable

and that differences between Polars versions could all be handled in there

We could probably then remove _is_polars and _backend_version from narwhals.DataFrame

@FBruzzesi
Copy link
Member

Closed by #561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants