From 938031653b7727ce088b5e3e1460fca5de745b18 Mon Sep 17 00:00:00 2001 From: dangotbanned <125183946+dangotbanned@users.noreply.github.com> Date: Sun, 9 Feb 2025 16:49:24 +0000 Subject: [PATCH 1/3] chore(typing): remove unused ignores `utils.py` --- narwhals/utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/narwhals/utils.py b/narwhals/utils.py index 2a25ac4c0..a4db138e8 100644 --- a/narwhals/utils.py +++ b/narwhals/utils.py @@ -189,7 +189,7 @@ def to_native_namespace(self: Self) -> ModuleType: if self is Implementation.PYARROW: import pyarrow as pa # ignore-banned-import - return pa # type: ignore[no-any-return] + return pa if self is Implementation.PYSPARK: # pragma: no cover import pyspark.sql @@ -201,12 +201,12 @@ def to_native_namespace(self: Self) -> ModuleType: if self is Implementation.DASK: import dask.dataframe # ignore-banned-import - return dask.dataframe # type: ignore[no-any-return] + return dask.dataframe if self is Implementation.DUCKDB: import duckdb # ignore-banned-import - return duckdb # type: ignore[no-any-return] + return duckdb msg = "Not supported Implementation" # pragma: no cover raise AssertionError(msg) From 6907f3b9a2fc7751596b178c51c318eeb5d3a777 Mon Sep 17 00:00:00 2001 From: dangotbanned <125183946+dangotbanned@users.noreply.github.com> Date: Sun, 9 Feb 2025 16:52:21 +0000 Subject: [PATCH 2/3] chore(typing): remove unused ignores `_duckdb` --- narwhals/_duckdb/dataframe.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/narwhals/_duckdb/dataframe.py b/narwhals/_duckdb/dataframe.py index 53a8a6767..f548f3592 100644 --- a/narwhals/_duckdb/dataframe.py +++ b/narwhals/_duckdb/dataframe.py @@ -251,7 +251,7 @@ def schema(self: Self) -> dict[str, DType]: @property def columns(self: Self) -> list[str]: - return self._native_frame.columns # type: ignore[no-any-return] + return self._native_frame.columns def to_pandas(self: Self) -> pd.DataFrame: # only if version is v1, keep around for backcompat From 40ad4237505405f57a8503319db69418a13e417e Mon Sep 17 00:00:00 2001 From: dangotbanned <125183946+dangotbanned@users.noreply.github.com> Date: Sun, 9 Feb 2025 16:59:54 +0000 Subject: [PATCH 3/3] chore(typing): remove unused ignores `_arrow` + "fix" `write_csv` return value --- narwhals/_arrow/dataframe.py | 11 ++++++----- narwhals/_arrow/series.py | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/narwhals/_arrow/dataframe.py b/narwhals/_arrow/dataframe.py index e2c52c966..bf2456493 100644 --- a/narwhals/_arrow/dataframe.py +++ b/narwhals/_arrow/dataframe.py @@ -109,7 +109,7 @@ def _from_native_frame( @property def shape(self: Self) -> tuple[int, int]: - return self._native_frame.shape # type: ignore[no-any-return] + return self._native_frame.shape def __len__(self: Self) -> int: return len(self._native_frame) @@ -131,7 +131,7 @@ def rows( def rows(self: Self, *, named: bool) -> list[tuple[Any, ...]] | list[dict[str, Any]]: if not named: return list(self.iter_rows(named=False, buffer_size=512)) # type: ignore[return-value] - return self._native_frame.to_pylist() # type: ignore[no-any-return] + return self._native_frame.to_pylist() def iter_rows( self: Self, *, named: bool, buffer_size: int @@ -302,7 +302,7 @@ def estimated_size(self: Self, unit: SizeUnit) -> int | float: @property def columns(self: Self) -> list[str]: - return self._native_frame.schema.names # type: ignore[no-any-return] + return self._native_frame.schema.names def simple_select(self, *column_names: str) -> Self: return self._from_native_frame( @@ -676,8 +676,9 @@ def write_csv(self: Self, file: str | Path | BytesIO | None) -> str | None: if file is None: csv_buffer = pa.BufferOutputStream() pa_csv.write_csv(pa_table, csv_buffer) - return csv_buffer.getvalue().to_pybytes().decode() # type: ignore[no-any-return] - return pa_csv.write_csv(pa_table, file) # type: ignore[no-any-return] + return csv_buffer.getvalue().to_pybytes().decode() + pa_csv.write_csv(pa_table, file) + return None def is_unique(self: Self) -> ArrowSeries: from narwhals._arrow.series import ArrowSeries diff --git a/narwhals/_arrow/series.py b/narwhals/_arrow/series.py index 1847dae6a..7dac7dad7 100644 --- a/narwhals/_arrow/series.py +++ b/narwhals/_arrow/series.py @@ -355,7 +355,7 @@ def scatter(self: Self, indices: int | Sequence[int], values: Any) -> Self: return self._from_native_series(result) def to_list(self: Self) -> list[Any]: - return self._native_series.to_pylist() # type: ignore[no-any-return] + return self._native_series.to_pylist() def __array__(self: Self, dtype: Any = None, copy: bool | None = None) -> np.ndarray: return self._native_series.__array__(dtype=dtype, copy=copy)