Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDS does not process 56 bits (or more) arguments properly #3174

Closed
Shivaly-Reddy opened this issue Jan 30, 2025 · 6 comments
Closed

GDS does not process 56 bits (or more) arguments properly #3174

Shivaly-Reddy opened this issue Jan 30, 2025 · 6 comments
Labels
High Priority High Priority issue that needs to be resolved.

Comments

@Shivaly-Reddy
Copy link
Collaborator

Shivaly-Reddy commented Jan 30, 2025

I have a command with an argument that is a struct. It contains U64/U8/bool. In fprime-gds when I tried to enter a U64 with 56 bits or more, it processes the argument incorrectly. However, it's fine with 52 bits and below. For example,

U64 --> 0xffffc002001004 gets converted to ” 0xffffc002001000" (56 bits)
U64 --> 0xfffc002001004 gets converted to 0xfffc002001004 (52 bits -- as expected)

Note: I modified the command to use individual arguments instead of the struct and U64 there still/also has the same problem.

@LeStarch LeStarch transferred this issue from nasa/fpp Jan 30, 2025
@LeStarch
Copy link
Collaborator

Moved to F Prim as it is a GDS issue.

@LeStarch LeStarch added the High Priority High Priority issue that needs to be resolved. label Jan 30, 2025
@LeStarch
Copy link
Collaborator

This is an issue with raw values in JavaScript, which are limited to 56 bits of precision. We fixed the processing with scalars, but it appears we need to fix it with Arrays and Structs too.

@arizvi786
Copy link
Collaborator

@LeStarch do we know when this issue can be made available in a release tag?

@LeStarch
Copy link
Collaborator

LeStarch commented Feb 1, 2025

We are still investigating a root cause for this issue. Can probably schedule a path forward next week!

@LeStarch LeStarch added this to the Release v3.6.0 milestone Feb 5, 2025
LeStarch added a commit to LeStarch/fprime-gds that referenced this issue Feb 6, 2025
@LeStarch
Copy link
Collaborator

LeStarch commented Feb 6, 2025

@arizvi786 a PR is in to fix this issue, and will be included in the next release!

@arizvi786
Copy link
Collaborator

@arizvi786 a PR is in to fix this issue, and will be included in the next release!

@LeStarch thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority High Priority issue that needs to be resolved.
Projects
None yet
Development

No branches or pull requests

3 participants