Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize sample data directories as proof-of-concept experiments #52

Open
3 of 4 tasks
hannah-rae opened this issue Aug 2, 2021 · 4 comments
Open
3 of 4 tasks
Assignees

Comments

@hannah-rae
Copy link
Contributor

hannah-rae commented Aug 2, 2021

The sample_data subdirectories were meant to provide a small sample dataset for each use case to demonstrate and test the complete workflow using data from each use case/data type. The planetary_rover subdirectory gives a good example of how we can provide all the data to enable proof-of-concept experiments for each use case in this directory. We should update the other use case subdirs to match this structure (including documentation for running the experiment in the README).

When we start running full-dataset experiments, we can put the config and results files in the exp/ directory. Config files in the example_config directory should be generic templates for the available data types.

  • Planetary rover
  • Earth - time series (field data)
  • Earth - raster (volcano)
  • DES
@hannah-rae
Copy link
Contributor Author

Note from meeting on 8/2: @wkiri will re-organize planetary_rover to move reference results to a test directory, so we will wait for those updates before modifying the other subdirs to mirror it.

@wkiri
Copy link
Collaborator

wkiri commented Aug 16, 2021

I have moved the planetary_rover reference results to test/ref-results/planetary_rover/. I am thinking each use case could create a similar directory under test/ref-results/.

I also updated the instructions in sample_data/planetary_rover/png/exp/README.md to suggest a diff with the results in the new location after running the run_dora.sh script.

These updates are done in the issue52-reorg-testdata branch; I suggest that the corresponding updates for the other use cases can be done here as well, and then we can merge that branch when all are updated.

wkiri added a commit that referenced this issue Aug 19, 2021
@wkiri
Copy link
Collaborator

wkiri commented Aug 31, 2021

@hannah-rae and @urebbapr , Feel free to make your updates to test cases similarly within this branch.

@hannah-rae
Copy link
Contributor Author

This issue is related to #14 which uses the sample data for unit tests. Both branches are staying open in case we have time to add DES data/tests later. I merged the feature branch for this issue (issue52-reorg-testdata) into the branch for #52 (issue14-unittests) and merged that to master, so changes from both should be reflected on the master branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants