Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Structurize] Schematic Overhauls #38

Closed
25 of 35 tasks
natrow opened this issue Jan 19, 2023 · 3 comments
Closed
25 of 35 tasks

[Structurize] Schematic Overhauls #38

natrow opened this issue Jan 19, 2023 · 3 comments
Labels
enhancement New feature or request needs mod

Comments

@natrow
Copy link
Owner

natrow commented Jan 19, 2023 •
edited
Loading

Add new GUI options for:

  • Base wood type selection
  • Base stone type selection
  • Soil type selection
  • Initialize selection
  • Use town hall as default selection

Placement block implementation

  • Register placeholder
    • Wood
    • Stone
    • Soil
  • Add proper block tags to placeholder variants (including DO tags)
  • Fix visuals
    • Looms
    • Grass variants

Data storage implementation

  • BuildSettings mixin
  • AbstractBlockHut mixin
  • Some way to safely leak info to PlacementHandler (possibly with PlacementSettings)

Block rendering implementation

  • BlueprintRenderer mixin for Block
    • Wood
    • Stone
    • Soil
    • Donum Ornamentum support
  • BlueprintUtils mixin for BlockEntity
    • Wood
    • Stone
    • Soil
    • Donum Ornamentum support

Block placement implementation

  • PlacementHandler function canHandle()
    • Donum Ornamentum support
  • PlacementHandler function getRequiredItems()
    • Donum Ornamentum support
  • PlacementHandler function handle()
    • Donum Ornamentum support

Misc:

  • Block detection during upgrades?
  • Make fallback stone configurable
  • Show selections in hut/upgrade GUI?
@natrow natrow added enhancement New feature or request needs mod labels Jan 19, 2023
@natrow natrow pinned this issue Feb 3, 2023
@natrow
Copy link
Owner Author

natrow commented Feb 3, 2023

Created a new feature branch for these changes.

@natrow natrow mentioned this issue Feb 3, 2023
Closed
natrow added a commit that referenced this issue Feb 5, 2023
@natrow
Store material selection in block hut NBT
3617b48 
Also initialize GUI selections

Part of #38
natrow added a commit that referenced this issue Feb 7, 2023
@natrow
Added wood placeholder blocks
2c152d3 
TODO: update textures

Part of #38
natrow added a commit that referenced this issue Jun 10, 2023
@natrow
Rock, Wood & Soil placeholders
c888d0c 
Part of #38.

 - Added wood & soil placeholders
 - Renamed references from stone type to rock type
 - Removed duplicated textures & models, now only uses minimal config

Todo: missing block tags for extra functionaility (e.g. fences connecting)
natrow added a commit that referenced this issue Jun 26, 2023
@natrow
Placeholder previews & start of placement handlers
531c64d 
Part of #38.

 - Wood placeholder previews
 - Start of wood placement handlers

Todo: door bug, testing inventories, fix lectern, stone/soil support, handle dynamic wood variants in placement handler (further testing needed)
natrow added a commit that referenced this issue Jul 19, 2023
@natrow
Placeholder previews & start of placement handlers
02c16ed 
Part of #38.

 - Disabled `PlacementHandler` until render behavior complete
 - Fixed tile entity rendering
 - Todo: stone & soil placeholder rendering
natrow added a commit that referenced this issue Jul 19, 2023
@natrow
Stone placeholder previews
91e94c9 
Part of #38.

 - Created soil placeholder look-up table
 - Implemented soil placeholder previews

Todo: fix grass variant visuals
natrow added a commit that referenced this issue Jul 19, 2023
@natrow
Placeholder grass visual bug
2847cf0 
Part of #38.

 - Added proper render handling for grass-type placeholders
@natrow
Copy link
Owner Author

natrow commented Jul 22, 2023

Affected by #42

natrow added a commit that referenced this issue Jul 22, 2023
@natrow
More placeholder blocks & tags
ffa2b11 
Part of #38.

 - Added placeholder mud brick decorations
 - Added placeholder sign & support beams
 - Added new placeholder blocks to LUT
 - Refactored LUT code to reduce clutter & re-use more
 - Added missing block and item tags to placeholders
natrow added a commit that referenced this issue Aug 2, 2023
@natrow
Placeholder placement handler implementation
3d0b6dc 
Part of #38.

 - Code reformat using Google's java formatter
 - Fixed `getRequiredItems()` implementations ignoring complete
 - Created placement handler for placeholder blocks
 - Mixin for PlacementSettings to include material information
 - Mixin for StructurePlacer to give material information to getRequiredItems()
 - Several Mixins to load material information into PlacementSettings where necessary
   - BuildTool*Message
   - Settings.getActiveStructure()

TODO: `AbstractEntityAIStructure.loadStructure()` to support builder, and several other contexts
@natrow
Copy link
Owner Author

natrow commented May 27, 2024

Abandoning in favor of solution in #43

@natrow natrow closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Structurize Schematic Overhauls natrow/tfc_minecolonies
1 participant
@natrow