You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After implementing #26 , we propose a set of changes that will represent last model changes needed to release 1.0 version of the plugin.
Add RoutingInstanceTemplate model
Add PeerGroupTemplate, AddressFamilyTemplate, and PeerGroupAddressFamilyTemplate models that can be created as children of a RoutingInstanceTemplate in order to fully model a "template" BGP configuration. This will work similarly to how DeviceType and InterfaceTemplate/ConsolePortTemplate/etc. work in core, i.e. instantiating a RoutingInstance from a RoutingInstanceTemplate will also create PeerGroups corresponding to its PeerGroupTemplates, etc.
Automatically create RoutingInstance components based on its RoutingInstanceTemplate : add AddressFamily, PeerGroup, and AddressFamilyPeerGroup objects automatically as defined under RoutingInstanceTemplate , carry over attributes and copy globally pre-defined extra attributes into device-specific instances
Also similar to core, creation from a template is a one-time event; changing a RoutingInstanceTemplate and its descendant models later will not retroactively result in updates to existing instances that were originally based on this template.
Remove any existing peergroup_template references in extra_attributes_inheritance or property_inheritance
Remove existing PeerGroupTemplate model as the related PeerGroup parent - this is a last BREAKING change that will impact inheritance/modelling and might result in data loss (plugin will not provide data migration)
This changes will happen after implementation of #26 via #132
The text was updated successfully, but these errors were encountered:
I'd propose RoutingInstanceTemplate rather than RoutingInstanceType as a clearer name.
Will probably need PeerGroupTemplate, AddressFamilyTemplate, and PeerGroupAddressFamilyTemplate models that can be created as children of a RoutingInstanceTemplate in order to fully model a "template" BGP configuration. This will work similarly to how DeviceType and InterfaceTemplate/ConsolePortTemplate/etc. work in core, i.e. instantiating a RoutingInstance from a RoutingInstanceTemplate will also create PeerGroups corresponding to its PeerGroupTemplates, etc.
Also similar to core, creation from a template is a one-time event; changing a RoutingInstanceTemplate and its descendant models later will not retroactively result in updates to existing instances that were originally based on this template.
mzbroch
changed the title
Add RoutingInstanceType, remove PeerGroupTemplate
Add RoutingInstanceType, modify PeerGroupTemplate behaviour
Sep 27, 2023
After implementing #26 , we propose a set of changes that will represent last model changes needed to release 1.0 version of the plugin.
RoutingInstanceTemplate
modelPeerGroupTemplate
,AddressFamilyTemplate
, andPeerGroupAddressFamilyTemplate
models that can be created as children of aRoutingInstanceTemplate
in order to fully model a "template" BGP configuration. This will work similarly to howDeviceType
andInterfaceTemplate
/ConsolePortTemplate
/etc. work in core, i.e. instantiating aRoutingInstance
from aRoutingInstanceTemplate
will also createPeerGroups
corresponding to itsPeerGroupTemplates
, etc.RoutingInstance
components based on itsRoutingInstanceTemplate
: addAddressFamily
,PeerGroup
, andAddressFamilyPeerGroup
objects automatically as defined underRoutingInstanceTemplate
, carry over attributes and copy globally pre-defined extra attributes into device-specific instancesRoutingInstanceTemplate
and its descendant models later will not retroactively result in updates to existing instances that were originally based on this template.peergroup_template
references in extra_attributes_inheritance or property_inheritancePeerGroupTemplate
model as the relatedPeerGroup
parent - this is a last BREAKING change that will impact inheritance/modelling and might result in data loss (plugin will not provide data migration)This changes will happen after implementation of #26 via #132
The text was updated successfully, but these errors were encountered: