Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate uniqueness of ASN number #70

Open
Kircheneer opened this issue Dec 9, 2022 · 4 comments
Open

Re-evaluate uniqueness of ASN number #70

Kircheneer opened this issue Dec 9, 2022 · 4 comments

Comments

@Kircheneer
Copy link
Contributor

Environment

  • Nautobot version: 1.5.4
  • nautobot-bgp-models version: 0.7.0-beta.1

Proposed Functionality

Remove the unique=True parameter to the ASNField on the ASN model.

Use Case

Re-use of private ASNs between either different locations of the same tenant or possibly between different tenants altogether.

@Kircheneer
Copy link
Contributor Author

Kircheneer commented Dec 15, 2022

Considerations:

  • Validate that two distinct instances of equal-numbered ASNs can't peer?
  • How does this affect form rendering?
  • How does this affect GraphQL responses?

@Kircheneer
Copy link
Contributor Author

Could be implemented by adding

  • tenant
  • location

fields on the model, dropping the uniqueness constraint on the asn field and adding a new one for the combination of location/tenant/asn.

@itdependsnetworks
Copy link

Validate that two distinct instances of ASNs can't peer?

If this is current state, I would think it was incorrect, if this is future state, I am not understanding why this would be helpful?

@Kircheneer
Copy link
Contributor Author

Validate that two distinct instances of ASNs can't peer?

If this is current state, I would think it was incorrect, if this is future state, I am not understanding why this would be helpful?

Good catch - I added the little word "equal-numbered"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants