Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the configurable statuses in this app #276

Open
gsnider2195 opened this issue Oct 7, 2024 · 0 comments
Open

Revisit the configurable statuses in this app #276

gsnider2195 opened this issue Oct 7, 2024 · 0 comments
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping

Comments

@gsnider2195
Copy link
Contributor

gsnider2195 commented Oct 7, 2024

The plugin configurations need to be revisited to behave consistently with other apps and nautobot core behavior. Recommend removing the default_status configuration and, at the very least renaming allowed_status to allowed_statuses since it's a list but preferably implement this as an enabled boolean on the related models. The name of this configuration is ambiguous and it only applies to the capirca firewall so it should be named appropriately.

@gsnider2195 gsnider2195 added type: housekeeping impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping
Projects
None yet
Development

No branches or pull requests

1 participant