-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checker for arbitrary issue tracker links #207
Comments
Requires #224 |
You mean, heylogs will use GitHub's API to fetch the configuration and then check the links according to it? 😅🤩🤣🤣 My solution was a "simple" pattern matching approach not requiring any configuration. |
That's a good idea but it would render the check unreliable and a bit slower. |
You mean, you will cache the API result? 🤣🤣 (I am in creative mood, don't take too serious 😅) |
In https://github.com/nbbrd/heylogs/blob/develop/heylogs-api/src/main/java/internal/heylogs/ExtendedRules.java, there is a check for GitHub links. Other links should also work.
Example from https://github.com/openjdk/jtreg/:
I think, JIRA has a similar pattern. Maybe, one can use a kind of regex?
If
tag1
andtag2
are equal,number1
andnumber2
have to be equal.To support GitHub enterprise, one could even extend
If
prefix1
andprefix2
are equal,number1
andnumber2
have to be equal.The text was updated successfully, but these errors were encountered: