Extension breaks when certain emojis in title.

[Paris-Man]

Clicking the save link button does nothing with certain emojis in a tab's title. For example, when they are in a Twitter user's handle.

Getting rid of tab.title in in filename in generate_link.js fixes it. But I guess then you have to name files manually.

[nbeaver]

Hi @Paris-Man, I'm having some difficulty reproducing this. The @hourlyfish Twitter account is gone, and the Emojipedia homepage works fine for me:

link-to-📙_Emojipedia_—_😃_Home_of_Emoji_Meanings_💁👌🎍😍_emojipedia.org.link.html

As does the page for recent emoji like heart hands:

link-to-🫶_Heart_Hands_Emoji_emojipedia.org.link.html

I'm using Firefox 105.0 on Ubuntu 18.04 if that matters.

[nbeaver]

The @hourlyfish Twitter account is back, but no emojis in the title. However, I think this may have been due to a zero-width joiner in the page title, e.g. here:

https://emojipedia.org/man-farmer/

Trying to run downloads.download() on a filename containing a ZWJ results in a failed download and an "Error: filename must not contain illegal characters" message.

I've added a fix to strip out the ZWJ and I'll post a new version shortly, but there are probably other page titles that will fail to sanitize. Only the browser truly knows what characters are illegal, but the WebExtensions API doesn't provide access to the browser's filename sanitize function, so I don't know of a robust way to fix this in the general case.

Related:

solorey/Art-Saver#18

eight04/image-picka#208

https://bugzilla.mozilla.org/show_bug.cgi?id=1791530

https://stackoverflow.com/questions/73036830/sanitise-unicode-pair-for-filename-in-javascript